This job view page is being replaced by Spyglass soon. Check out the new job view.
PRlintongj: Implemented CreateSnapshot and DeleteSnapshot capabilities in CSI driver without handling idempotency and limit check
Tests 0 failed / 0 succeeded
Started2021-07-21 18:19
Refs 1180

No Test Failures!

Error lines from build-log.txt

... skipping 94 lines ...
level=info msg="[linters context/goanalysis] analyzers took 4m45.122826087s with top 10 stages: buildir: 3m43.678555832s, nilness: 23.339095079s, inspect: 5.063363987s, typedness: 2.830368835s, fact_purity: 2.671038869s, fact_deprecated: 2.624688499s, ctrlflow: 2.588785857s, printf: 2.433599846s, SA5012: 1.622196739s, S1038: 1.323254681s"
level=info msg="[runner] Issues before processing: 123, after processing: 15"
level=info msg="[runner] Processors filtering stat (out/in): path_prettifier: 123/123, autogenerated_exclude: 34/123, exclude: 34/34, uniq_by_line: 15/15, diff: 15/15, max_per_file_from_linter: 15/15, path_shortener: 15/15, severity-rules: 15/15, sort_results: 15/15, max_from_linter: 15/15, filename_unadjuster: 123/123, skip_files: 123/123, skip_dirs: 123/123, identifier_marker: 34/34, exclude-rules: 16/34, cgo: 123/123, nolint: 15/16, max_same_issues: 15/15, source_code: 15/15, path_prefixer: 15/15"
level=info msg="[runner] processing took 21.046264ms with stages: nolint: 17.842952ms, autogenerated_exclude: 1.011959ms, path_prettifier: 603.67µs, identifier_marker: 535.614µs, source_code: 374.321µs, exclude-rules: 328.191µs, skip_dirs: 266.114µs, max_same_issues: 26.853µs, uniq_by_line: 16.692µs, cgo: 15.186µs, path_shortener: 8.66µs, filename_unadjuster: 7.583µs, max_from_linter: 2.78µs, max_per_file_from_linter: 2.293µs, skip_files: 1.028µs, diff: 884ns, sort_results: 537ns, exclude: 456ns, severity-rules: 283ns, path_prefixer: 208ns"
level=info msg="[runner] linters took 45.058477718s with stages: goanalysis_metalinter: 45.037187415s"
pkg/common/cns-lib/volume/manager.go:1538: line is 136 characters (lll)
func (m *defaultManager) CreateSnapshot(ctx context.Context, volumeID string, desc string) (string, string, string, *time.Time, error) {
pkg/common/cns-lib/volume/manager.go:1562: line is 154 characters (lll)
	log.Infof("Calling CnsClient.CreateSnapshots: VolumeID [%q] Description [%q] cnsSnapshotCreateSpecList [%#v]", volumeID, desc, cnsSnapshotCreateSpecList)
pkg/common/cns-lib/volume/manager.go:1572: line is 126 characters (lll)
		log.Errorf("Failed to get taskInfo for CreateSnapshots task from vCenter %q with err: %v", m.virtualCenter.Config.Host, err)
pkg/common/cns-lib/volume/manager.go:1580: line is 128 characters (lll)
		log.Errorf("unable to find the task result for CreateSnapshots task from vCenter %q. taskID: %q, opId: %q createResults: %+v",
pkg/common/cns-lib/volume/manager.go:1581: line is 132 characters (lll)
			m.virtualCenter.Config.Host, createSnapshotsTaskInfo.Task.Value, createSnapshotsTaskInfo.ActivationId, createSnapshotsTaskResult)
pkg/common/cns-lib/volume/manager.go:1599: line is 179 characters (lll)
	log.Infof("CreateSnapshot: Snapshot created successfully. SnapshotID: %q, SnapshotCreateTime: %q, opId: %q", snapshotID, snapshotCreateTime, createSnapshotsTaskInfo.ActivationId)
pkg/common/cns-lib/volume/manager.go:1630: line is 155 characters (lll)
	log.Infof("Calling CnsClient.DeleteSnapshots: VolumeID [%q] SnapshotID [%q] cnsSnapshotDeleteSpecList [%#v]", volumeID, snapshotID, cnsSnapshotDeleteSpec)
pkg/common/cns-lib/volume/manager.go:1640: line is 126 characters (lll)
		log.Errorf("Failed to get taskInfo for DeleteSnapshots task from vCenter %q with err: %v", m.virtualCenter.Config.Host, err)
pkg/common/cns-lib/volume/manager.go:1643: line is 129 characters (lll)
	log.Infof("DeleteSnapshots: VolumeID: %q, SnapshotID: %q, opId: %q", volumeID, snapshotID, deleteSnapshotsTaskInfo.ActivationId)
pkg/common/cns-lib/volume/manager.go:1648: line is 128 characters (lll)
		log.Errorf("unable to find the task result for DeleteSnapshots task from vCenter %q. taskID: %q, opId: %q createResults: %+v",
pkg/common/cns-lib/volume/manager.go:1649: line is 132 characters (lll)
			m.virtualCenter.Config.Host, deleteSnapshotsTaskInfo.Task.Value, deleteSnapshotsTaskInfo.ActivationId, deleteSnapshotsTaskResult)
pkg/common/cns-lib/volume/manager.go:1664: line is 153 characters (lll)
	log.Infof("DeleteSnapshot: Snapshot %s deleted successfully. volumeID: %q, opId: %q", deletedSnapshotID, volumeID, deleteSnapshotsTaskInfo.ActivationId)
pkg/csi/service/common/vsphereutil.go:655: line is 122 characters (lll)
func CreateSnapshotUtil(ctx context.Context, manager *Manager, volumeID string, desc string) (string, *time.Time, error) {
pkg/csi/service/common/vsphereutil.go:664: line is 148 characters (lll)
	log.Debugf("Successfully created snapshot %q with description, %q, on volume: %q at timestamp %q", snapshotID, desc, volumeID, *snapshotCreateTime)
pkg/csi/service/vanilla/controller.go:1252: line is 142 characters (lll)
		return nil, logger.LogNewErrorCodef(log, codes.Internal, "Failed to delete snapshot %q on volume %q. Error: %+v", snapshotID, volumeID, err)
level=info msg="File cache stats: 217 entries of total size 3.0MiB"
level=info msg="Memory: 1066 samples, avg is 568.2MB, max is 2029.7MB"
level=info msg="Execution took 1m56.257732672s"
make: *** [Makefile:375: golangci-lint] Error 1