This job view page is being replaced by Spyglass soon. Check out the new job view.
PRlintongj: Implemented CreateSnapshot and DeleteSnapshot capabilities in CSI driver without handling idempotency and limit check
Tests 0 failed / 0 succeeded
Started2021-07-21 01:42
Refs 1180

No Test Failures!

Error lines from build-log.txt

... skipping 94 lines ...
level=info msg="[linters context/goanalysis] analyzers took 4m7.04008567s with top 10 stages: buildir: 3m18.372406197s, nilness: 17.970062174s, inspect: 4.561992772s, fact_deprecated: 2.457841383s, ctrlflow: 2.317820097s, typedness: 2.262161846s, fact_purity: 2.119318591s, printf: 1.968833631s, SA5012: 1.125961995s, S1038: 1.087980428s"
level=info msg="[runner] Issues before processing: 123, after processing: 15"
level=info msg="[runner] Processors filtering stat (out/in): cgo: 123/123, filename_unadjuster: 123/123, path_prettifier: 123/123, autogenerated_exclude: 34/123, nolint: 15/16, skip_files: 123/123, skip_dirs: 123/123, max_per_file_from_linter: 15/15, max_same_issues: 15/15, max_from_linter: 15/15, source_code: 15/15, identifier_marker: 34/34, exclude: 34/34, exclude-rules: 16/34, severity-rules: 15/15, uniq_by_line: 15/15, diff: 15/15, path_shortener: 15/15, path_prefixer: 15/15, sort_results: 15/15"
level=info msg="[runner] processing took 19.171969ms with stages: nolint: 16.546087ms, autogenerated_exclude: 646.203µs, path_prettifier: 581.489µs, identifier_marker: 539.63µs, exclude-rules: 323.842µs, source_code: 286.845µs, skip_dirs: 157.267µs, filename_unadjuster: 24.537µs, uniq_by_line: 24.075µs, max_same_issues: 13.799µs, cgo: 13.49µs, path_shortener: 6.826µs, max_per_file_from_linter: 3.276µs, max_from_linter: 2.343µs, diff: 543ns, skip_files: 540ns, exclude: 509ns, sort_results: 274ns, severity-rules: 243ns, path_prefixer: 151ns"
level=info msg="[runner] linters took 39.863899777s with stages: goanalysis_metalinter: 39.844427498s"
pkg/common/cns-lib/volume/manager.go:1538: line is 136 characters (lll)
func (m *defaultManager) CreateSnapshot(ctx context.Context, volumeID string, desc string) (string, string, string, *time.Time, error) {
pkg/common/cns-lib/volume/manager.go:1562: line is 154 characters (lll)
	log.Infof("Calling CnsClient.CreateSnapshots: VolumeID [%q] Description [%q] cnsSnapshotCreateSpecList [%#v]", volumeID, desc, cnsSnapshotCreateSpecList)
pkg/common/cns-lib/volume/manager.go:1572: line is 126 characters (lll)
		log.Errorf("Failed to get taskInfo for CreateSnapshots task from vCenter %q with err: %v", m.virtualCenter.Config.Host, err)
pkg/common/cns-lib/volume/manager.go:1580: line is 128 characters (lll)
		log.Errorf("unable to find the task result for CreateSnapshots task from vCenter %q. taskID: %q, opId: %q createResults: %+v",
pkg/common/cns-lib/volume/manager.go:1581: line is 132 characters (lll)
			m.virtualCenter.Config.Host, createSnapshotsTaskInfo.Task.Value, createSnapshotsTaskInfo.ActivationId, createSnapshotsTaskResult)
pkg/common/cns-lib/volume/manager.go:1599: line is 179 characters (lll)
	log.Infof("CreateSnapshot: Snapshot created successfully. SnapshotID: %q, SnapshotCreateTime: %q, opId: %q", snapshotID, snapshotCreateTime, createSnapshotsTaskInfo.ActivationId)
pkg/common/cns-lib/volume/manager.go:1630: line is 155 characters (lll)
	log.Infof("Calling CnsClient.DeleteSnapshots: VolumeID [%q] SnapshotID [%q] cnsSnapshotDeleteSpecList [%#v]", volumeID, snapshotID, cnsSnapshotDeleteSpec)
pkg/common/cns-lib/volume/manager.go:1640: line is 126 characters (lll)
		log.Errorf("Failed to get taskInfo for DeleteSnapshots task from vCenter %q with err: %v", m.virtualCenter.Config.Host, err)
pkg/common/cns-lib/volume/manager.go:1643: line is 129 characters (lll)
	log.Infof("DeleteSnapshots: VolumeID: %q, SnapshotID: %q, opId: %q", volumeID, snapshotID, deleteSnapshotsTaskInfo.ActivationId)
pkg/common/cns-lib/volume/manager.go:1648: line is 128 characters (lll)
		log.Errorf("unable to find the task result for DeleteSnapshots task from vCenter %q. taskID: %q, opId: %q createResults: %+v",
pkg/common/cns-lib/volume/manager.go:1649: line is 132 characters (lll)
			m.virtualCenter.Config.Host, deleteSnapshotsTaskInfo.Task.Value, deleteSnapshotsTaskInfo.ActivationId, deleteSnapshotsTaskResult)
pkg/common/cns-lib/volume/manager.go:1664: line is 153 characters (lll)
	log.Infof("DeleteSnapshot: Snapshot %s deleted successfully. volumeID: %q, opId: %q", deletedSnapshotID, volumeID, deleteSnapshotsTaskInfo.ActivationId)
pkg/csi/service/common/vsphereutil.go:651: line is 122 characters (lll)
func CreateSnapshotUtil(ctx context.Context, manager *Manager, volumeID string, desc string) (string, *time.Time, error) {
pkg/csi/service/common/vsphereutil.go:660: line is 148 characters (lll)
	log.Debugf("Successfully created snapshot %q with description, %q, on volume: %q at timestamp %q", snapshotID, desc, volumeID, *snapshotCreateTime)
pkg/csi/service/vanilla/controller.go:1240: line is 142 characters (lll)
		return nil, logger.LogNewErrorCodef(log, codes.Internal, "Failed to delete snapshot %q on volume %q. Error: %+v", snapshotID, volumeID, err)
level=info msg="File cache stats: 217 entries of total size 3.0MiB"
level=info msg="Memory: 935 samples, avg is 531.6MB, max is 2031.6MB"
level=info msg="Execution took 1m43.812485531s"
make: *** [Makefile:375: golangci-lint] Error 1