This job view page is being replaced by Spyglass soon. Check out the new job view.
PRDirectXMan12: :bug: prevent controller.New and manager's errChan from leaking goroutines
ResultFAILURE
Tests 0 failed / 0 succeeded
Started2019-10-29 21:04
Elapsed2m20s
Revision5c7efdd48c422b386f11e703b8b8149a274ec3d8
Refs 651

No Test Failures!


Error lines from build-log.txt

... skipping 624 lines ...
manger.Manager
/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:45
  Start
  /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:239
    with defaults
    /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:332
      should return an error if it can't start the cache [It]
      /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:278

      Timed out

      /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:278
------------------------------
2019-10-29T21:06:33.522Z	ERROR	controller-runtime.manager	SignalError called without an (with a nil) error, which should never happen, ignoring
github.com/go-logr/zapr.(*zapLogger).Error
	/home/prow/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/manager.(*errSignaler).SignalError
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:174
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).waitForCache.func1
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:500
• Failure in Spec Setup (BeforeEach) [0.000 seconds]
manger.Manager
/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:45
  Start [BeforeEach]
  /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:239
    with defaults
    /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:332
      should return an error if any Components fail to Start
      /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:291

      Expected an error, got nil

      /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:286
------------------------------
•
------------------------------
•! Panic in Spec Setup (BeforeEach) [0.000 seconds]
... skipping 5 lines ...
    /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:336
      should Start each Component
      /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:241

      Test Panicked
      
      Your test failed.
      Ginkgo panics to prevent subsequent assertions from running.
      Normally Ginkgo rescues this panic so you shouldn't see it.
      
      But, if you make an assertion in a goroutine, Ginkgo can't capture the panic.
      To circumvent this, you should call
      
... skipping 4 lines ...
      /home/prow/go/pkg/mod/github.com/onsi/ginkgo@v1.8.0/ginkgo_dsl.go:262

      Full Stack Trace
      	/home/prow/go/pkg/mod/github.com/onsi/ginkgo@v1.8.0/internal/leafnodes/runner.go:76 +0x5f
      panic(0x14a2960, 0x18b2d50)
      	/usr/local/go/src/runtime/panic.go:522 +0x1b5
      github.com/onsi/ginkgo.Fail(0xc0000f4ce0, 0x1a, 0xc0006b0bd8, 0x1, 0x1)
      	/home/prow/go/pkg/mod/github.com/onsi/ginkgo@v1.8.0/ginkgo_dsl.go:262 +0xc8
      github.com/onsi/gomega/internal/assertion.(*Assertion).match(0xc000014b40, 0x18e9060, 0xc00001e890, 0x1, 0x0, 0x0, 0x0, 0xc00001e890)
      	/home/prow/go/pkg/mod/github.com/onsi/gomega@v1.5.0/internal/assertion/assertion.go:65 +0x345
      github.com/onsi/gomega/internal/assertion.(*Assertion).To(0xc000014b40, 0x18e9060, 0xc00001e890, 0x0, 0x0, 0x0, 0x1)
      	/home/prow/go/pkg/mod/github.com/onsi/gomega@v1.5.0/internal/assertion/assertion.go:38 +0xc7
      sigs.k8s.io/controller-runtime/pkg/manager.glob..func3.4.1.3(0xc0005a27e0)
... skipping 16 lines ...
manger.Manager
/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:45
  Start
  /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:239
    with leaderelection enabled
    /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:336
      should return an error if it can't start the cache [It]
      /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:278

      Timed out

      /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:278
------------------------------
2019-10-29T21:06:34.528Z	ERROR	controller-runtime.manager	SignalError called without an (with a nil) error, which should never happen, ignoring
github.com/go-logr/zapr.(*zapLogger).Error
	/home/prow/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/manager.(*errSignaler).SignalError
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:174
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startLeaderElection.func2
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:524
k8s.io/client-go/tools/leaderelection.(*LeaderElector).Run.func1
	/home/prow/go/pkg/mod/k8s.io/client-go@v0.0.0-20190918160344-1fbdaa4c8d90/tools/leaderelection/leaderelection.go:199
k8s.io/client-go/tools/leaderelection.(*LeaderElector).Run
	/home/prow/go/pkg/mod/k8s.io/client-go@v0.0.0-20190918160344-1fbdaa4c8d90/tools/leaderelection/leaderelection.go:202
2019-10-29T21:06:34.548Z	ERROR	controller-runtime.manager	SignalError called without an (with a nil) error, which should never happen, ignoring
github.com/go-logr/zapr.(*zapLogger).Error
	/home/prow/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/manager.(*errSignaler).SignalError
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:174
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).waitForCache.func1
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:500
• Failure [1.000 seconds]
manger.Manager
/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:45
  Start
  /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:239
    with leaderelection enabled
    /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:336
      should return an error if any Components fail to Start [It]
      /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:291

      Expected an error, got nil

      /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:286
------------------------------
2019-10-29T21:06:35.523Z	ERROR	controller-runtime.manager	SignalError called without an (with a nil) error, which should never happen, ignoring
github.com/go-logr/zapr.(*zapLogger).Error
	/home/prow/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/manager.(*errSignaler).SignalError
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:174
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startLeaderElection.func2
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:524
k8s.io/client-go/tools/leaderelection.(*LeaderElector).Run.func1
	/home/prow/go/pkg/mod/k8s.io/client-go@v0.0.0-20190918160344-1fbdaa4c8d90/tools/leaderelection/leaderelection.go:199
k8s.io/client-go/tools/leaderelection.(*LeaderElector).Run
	/home/prow/go/pkg/mod/k8s.io/client-go@v0.0.0-20190918160344-1fbdaa4c8d90/tools/leaderelection/leaderelection.go:208
2019-10-29T21:06:35.646Z	DEBUG	controller-runtime.manager	leader-election runnable finished	{"runnable type": "manager.RunnableFunc"}
2019-10-29T21:06:35.646Z	ERROR	controller-runtime.manager	SignalError called without an (with a nil) error, which should never happen, ignoring
github.com/go-logr/zapr.(*zapLogger).Error
	/home/prow/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/manager.(*errSignaler).SignalError
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:174
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startLeaderElectionRunnables.func1
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:478
2019-10-29T21:06:35.646Z	DEBUG	controller-runtime.manager	leader-election runnable finished	{"runnable type": "manager.RunnableFunc"}
... skipping 7 lines ...
  /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:239
    should start serving metrics
    /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:345
      should stop serving metrics when stop is called [It]
      /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:366

      Expected failure, but got no error.

      /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:319
------------------------------
2019-10-29T21:06:36.522Z	ERROR	controller-runtime.manager	SignalError called without an (with a nil) error, which should never happen, ignoring
github.com/go-logr/zapr.(*zapLogger).Error
	/home/prow/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/manager.(*errSignaler).SignalError
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:174
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).startLeaderElection.func2
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:524
k8s.io/client-go/tools/leaderelection.(*LeaderElector).Run.func1
	/home/prow/go/pkg/mod/k8s.io/client-go@v0.0.0-20190918160344-1fbdaa4c8d90/tools/leaderelection/leaderelection.go:199
k8s.io/client-go/tools/leaderelection.(*LeaderElector).Run
	/home/prow/go/pkg/mod/k8s.io/client-go@v0.0.0-20190918160344-1fbdaa4c8d90/tools/leaderelection/leaderelection.go:208
2019-10-29T21:06:36.538Z	INFO	controller-runtime.metrics	metrics server is starting to listen	{"addr": ":0"}
2019-10-29T21:06:36.538Z	INFO	controller-runtime.manager	starting metrics server	{"path": "/metrics"}
2019-10-29T21:06:36.539Z	ERROR	controller-runtime.manager	SignalError called without an (with a nil) error, which should never happen, ignoring
github.com/go-logr/zapr.(*zapLogger).Error
	/home/prow/go/pkg/mod/github.com/go-logr/zapr@v0.1.0/zapr.go:128
sigs.k8s.io/controller-runtime/pkg/manager.(*errSignaler).SignalError
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:174
sigs.k8s.io/controller-runtime/pkg/manager.(*controllerManager).serveMetrics.func1
	/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/internal.go:358
••••••••••••••••


Summarizing 6 Failures:

[Timeout...] manger.Manager Start with defaults [It] should return an error if it can't start the cache 
/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:278

[Fail] manger.Manager [BeforeEach] Start with defaults should return an error if any Components fail to Start 
/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:286

[Panic!] manger.Manager [BeforeEach] Start with leaderelection enabled should Start each Component 
/home/prow/go/pkg/mod/github.com/onsi/ginkgo@v1.8.0/ginkgo_dsl.go:262

[Timeout...] manger.Manager Start with leaderelection enabled [It] should return an error if it can't start the cache 
/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:278

[Fail] manger.Manager Start with leaderelection enabled [It] should return an error if any Components fail to Start 
/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:286

[Fail] manger.Manager Start should start serving metrics [It] should stop serving metrics when stop is called 
/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:319

Ran 40 of 40 Specs in 14.800 seconds
FAIL! -- 34 Passed | 6 Failed | 0 Pending | 0 Skipped
--- FAIL: TestSource (14.80s)
FAIL
FAIL	sigs.k8s.io/controller-runtime/pkg/manager	14.895s
ok  	sigs.k8s.io/controller-runtime/pkg/manager/signals	1.039s
?   	sigs.k8s.io/controller-runtime/pkg/metrics	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/patterns/application	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/patterns/operator	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/predicate	0.074s
ok  	sigs.k8s.io/controller-runtime/pkg/reconcile	0.080s
... skipping 16 lines ...