This job view page is being replaced by Spyglass soon. Check out the new job view.
PRvincepri: ⚠️ Refactor manager to avoid race conditions and provide clean shutdown
ResultFAILURE
Tests 1 failed / 1080 succeeded
Started2021-10-12 18:50
Elapsed4m37s
Revision04c2631e002b7b0eee6a331f76a52eb64d1e9838
Refs 1695

Test Failures


Manager Suite manger.Manager Start should start serving metrics should not serve anything other than metrics endpoint by default 0.05s

go run hack/e2e.go -v --test --test_args='--ginkgo.focus=Manager\sSuite\smanger\.Manager\sStart\sshould\sstart\sserving\smetrics\sshould\snot\sserve\sanything\sother\sthan\smetrics\sendpoint\sby\sdefault$'
/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:1134
Unexpected error:
    <*net.OpError | 0xc00024f7c0>: {
        Op: "accept",
        Net: "tcp",
        Source: nil,
        Addr: <*net.TCPAddr | 0xc000444c00>{
            IP: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0],
            Port: 46799,
            Zone: "",
        },
        Err: <*errors.errorString | 0xc000118160>{
            s: "use of closed network connection",
        },
    }
    accept tcp [::]:46799: use of closed network connection
occurred
/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:1125
				
				Click to see stdout/stderrfrom junit_Manager Suite_1.xml

Filter through log files | View test history on testgrid


Show 1080 Passed Tests

Show 39 Skipped Tests

Error lines from build-log.txt

... skipping 221 lines ...
Will run 78 of 78 specs

••••••••••••••••I1012 18:54:00.591568   17602 leaderelection.go:248] attempting to acquire leader lease default/test-leader-election-id-2...
I1012 18:54:00.630408   17602 leaderelection.go:258] successfully acquired lease default/test-leader-election-id-2
•I1012 18:54:00.880050   17602 leaderelection.go:248] attempting to acquire leader lease default/test-leader-election-id-3...
I1012 18:54:00.910399   17602 leaderelection.go:258] successfully acquired lease default/test-leader-election-id-3
E1012 18:54:00.911783   17602 leaderelection.go:330] error retrieving resource lock default/test-leader-election-id-3: Get "https://127.0.0.1:45153/api/v1/namespaces/default/configmaps/test-leader-election-id-3": context canceled
I1012 18:54:00.913433   17602 leaderelection.go:283] failed to renew lease default/test-leader-election-id-3: timed out waiting for the condition
•I1012 18:54:01.274058   17602 leaderelection.go:248] attempting to acquire leader lease default/test-leader-election-id...
I1012 18:54:01.293797   17602 leaderelection.go:258] successfully acquired lease default/test-leader-election-id
I1012 18:54:01.299241   17602 leaderelection.go:248] attempting to acquire leader lease default/test-leader-election-id...
•E1012 18:54:01.303331   17602 leaderelection.go:367] Failed to update lock: context canceled
I1012 18:54:01.303537   17602 leaderelection.go:283] failed to renew lease default/test-leader-election-id: timed out waiting for the condition
••••I1012 18:54:01.701897   17602 leaderelection.go:248] attempting to acquire leader lease 4ba9672a-2b8d-11ec-8fec-0ec89ee909b8_c9378cb8-57aa-44ad-9216-90bdf624bf4c...
I1012 18:54:01.702214   17602 leaderelection.go:258] successfully acquired lease 4ba9672a-2b8d-11ec-8fec-0ec89ee909b8_c9378cb8-57aa-44ad-9216-90bdf624bf4c
••••••••••••==================
WARNING: DATA RACE
Write at 0x00c0000ec048 by goroutine 127:
  sigs.k8s.io/controller-runtime/pkg/manager.(*startSignalingInformer).Start()
... skipping 174 lines ...
  /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:585
    should start serving metrics
    /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:1069
      should not serve anything other than metrics endpoint by default [It]
      /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:1134

      Unexpected error:
          <*net.OpError | 0xc00024f7c0>: {
              Op: "accept",
              Net: "tcp",
              Source: nil,
              Addr: <*net.TCPAddr | 0xc000444c00>{
                  IP: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0],
... skipping 8 lines ...
      occurred

      /home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:1125
------------------------------
1.6340648484855533e+09	INFO	controller-runtime.metrics	Metrics server is starting to listen	{"addr": ":0"}
1.6340648484866583e+09	INFO	Starting metrics server	{"path": "/metrics"}
1.6340648484928737e+09	ERROR	error received after stop sequence was engaged	{"error": "accept tcp [::]:39009: use of closed network connection"}
•••••••••••••••••

JUnit report was created: /logs/artifacts/junit_Manager Suite_1.xml


Summarizing 1 Failure:

[Fail] manger.Manager Start should start serving metrics [It] should not serve anything other than metrics endpoint by default 
/home/prow/go/src/sigs.k8s.io/controller-runtime/pkg/manager/manager_test.go:1125

Ran 78 of 78 Specs in 23.098 seconds
FAIL! -- 77 Passed | 1 Failed | 0 Pending | 0 Skipped
You're using deprecated Ginkgo functionality:
=============================================
Ginkgo 2.0 is under active development and will introduce (a small number of) breaking changes.
To learn more, view the migration guide at https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md
To comment, chime in at https://github.com/onsi/ginkgo/issues/711

... skipping 2 lines ...
  If this change will be impactful to you please leave a comment on https://github.com/onsi/ginkgo/issues/711
  Learn more at: https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=1.16.4

--- FAIL: TestSource (23.35s)
    testing.go:1092: race detected during execution of test
FAIL
FAIL	sigs.k8s.io/controller-runtime/pkg/manager	23.553s
ok  	sigs.k8s.io/controller-runtime/pkg/manager/signals	1.066s
?   	sigs.k8s.io/controller-runtime/pkg/metrics	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/patterns/application	[no test files]
?   	sigs.k8s.io/controller-runtime/pkg/patterns/operator	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/predicate	0.498s
?   	sigs.k8s.io/controller-runtime/pkg/ratelimiter	[no test files]
... skipping 7 lines ...
ok  	sigs.k8s.io/controller-runtime/pkg/webhook	15.871s
ok  	sigs.k8s.io/controller-runtime/pkg/webhook/admission	0.230s
?   	sigs.k8s.io/controller-runtime/pkg/webhook/admission/admissiontest	[no test files]
ok  	sigs.k8s.io/controller-runtime/pkg/webhook/authentication	0.313s
ok  	sigs.k8s.io/controller-runtime/pkg/webhook/conversion	0.305s
?   	sigs.k8s.io/controller-runtime/pkg/webhook/internal/metrics	[no test files]
FAIL