This job view page is being replaced by Spyglass soon. Check out the new job view.
PRabserari: fix-todo-in-pkg/util/taints
ResultFAILURE
Tests 1 failed / 36 succeeded
Started2020-10-17 00:02
Elapsed31m27s
Revisionb042d3435885e97879c60627aa815d67bdf16aa8
Refs 95656

Test Failures


verify gofmt 15s

make verify WHAT=gofmt
diff -u ./pkg/util/taints/taints.go.orig ./pkg/util/taints/taints.go
--- ./pkg/util/taints/taints.go.orig	2020-10-17 00:13:39.225754775 +0000
+++ ./pkg/util/taints/taints.go	2020-10-17 00:13:39.225754775 +0000
@@ -177,7 +177,7 @@
 	newTaints := append([]v1.Taint{}, taintsToAdd...)
 	oldTaints := node.Spec.Taints
 	// add taints that already existing but not updated to newTaints
-	addTaints,added := addTaints(oldTaints, &newTaints)
+	addTaints, added := addTaints(oldTaints, &newTaints)
 	newTaints = append(newTaints, addTaints...)
 	allErrs, deleted := deleteTaints(taintsToRemove, &newTaints)
 	if (added && deleted) || overwrite {
@@ -207,7 +207,7 @@
 }
 
 // addTaints adds the newTaints list to existing ones and updates the newTaints List.
-func addTaints(oldTaints []v1.Taint, newTaints *[]v1.Taint) (addTaints []v1.Taint,added bool) {
+func addTaints(oldTaints []v1.Taint, newTaints *[]v1.Taint) (addTaints []v1.Taint, added bool) {
 	for _, oldTaint := range oldTaints {
 		existsInNew := false
 		for _, taint := range *newTaints {

Run ./hack/update-gofmt.sh
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


Show 36 Passed Tests

Error lines from build-log.txt

... skipping 1526 lines ...
 	for _, oldTaint := range oldTaints {
 		existsInNew := false
 		for _, taint := range *newTaints {

Run ./hack/update-gofmt.sh
+++ exit code: 1
+++ error: 1
FAILED   verify-gofmt.sh	16s
Verifying verify-golint.sh

+++ Running case: verify.golint 
+++ working dir: /home/prow/go/src/k8s.io/kubernetes
+++ command: bash "hack/make-rules/../../hack/verify-golint.sh"
installing golint
... skipping 962 lines ...
  found dependency apimachinery
  found dependency api
Done.
+++ exit code: 0
SUCCESS  verify-publishing-bot.py	0s
========================
FAILED TESTS
========================
hack/make-rules/../../hack/verify-gofmt.sh
make: *** [Makefile:129: verify] Error 1
+ EXIT_VALUE=2
+ set +o xtrace
Cleaning up after docker in docker.
================================================================================
Cleaning up after docker
8d164dca9b65
... skipping 4 lines ...