This job view page is being replaced by Spyglass soon. Check out the new job view.
PRadtac: optimise defaultpreemption: enumerate fewer candidates
ResultFAILURE
Tests 4 failed / 33 succeeded
Started2020-09-16 11:39
Elapsed31m58s
Revision80c36642e2d55f9707b210a76bd7120b30b098e5
Refs 94814

Test Failures


verify gofmt 15s

make verify WHAT=gofmt
diff -u ./pkg/scheduler/framework/plugins/defaultpreemption/default_preemption.go.orig ./pkg/scheduler/framework/plugins/defaultpreemption/default_preemption.go
--- ./pkg/scheduler/framework/plugins/defaultpreemption/default_preemption.go.orig	2020-09-16 11:52:26.557467190 +0000
+++ ./pkg/scheduler/framework/plugins/defaultpreemption/default_preemption.go	2020-09-16 11:52:26.557467190 +0000
@@ -296,7 +296,7 @@
 	parallelCtx, cancel := context.WithCancel(ctx)
 
 	checkNode := func(i int) {
-		nodeInfoCopy := potentialNodes[(offset + i) % len(potentialNodes)].Clone()
+		nodeInfoCopy := potentialNodes[(offset+i)%len(potentialNodes)].Clone()
 		stateCopy := state.Clone()
 		pods, numPDBViolations, fits := selectVictimsOnNode(ctx, fh, stateCopy, pod, nodeInfoCopy, pdbs)
 		if fits {

Run ./hack/update-gofmt.sh
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify govet 4m36s

make verify WHAT=govet
# k8s.io/kubernetes/pkg/scheduler/framework/plugins/defaultpreemption
vet: pkg/scheduler/framework/plugins/defaultpreemption/default_preemption_test.go:686:11: undeclared name: dryRunPreemption
make[1]: *** [Makefile:388: vet] Error 1
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify spelling 3.15s

make verify WHAT=spelling
pkg/scheduler/framework/plugins/defaultpreemption/default_preemption.go:54:51: "precendence" is a misspelling of "precedence"
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify staticcheck 5m30s

make verify WHAT=staticcheck
Errors from staticcheck:
-: could not analyze dependency k8s.io/kubernetes/pkg/scheduler/framework/plugins/defaultpreemption [k8s.io/kubernetes/pkg/scheduler/framework/plugins/defaultpreemption.test] of k8s.io/kubernetes/pkg/scheduler/framework/plugins/defaultpreemption.test (compile)
pkg/scheduler/framework/plugins/defaultpreemption/default_preemption_test.go:686:11: undeclared name: dryRunPreemption (compile)

Please review the above warnings. You can test via:
  hack/verify-staticcheck.sh <failing package>
If the above warnings do not make sense, you can exempt the line or file. See:
  https://staticcheck.io/docs/#ignoring-problems
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


Show 33 Passed Tests