This job view page is being replaced by Spyglass soon. Check out the new job view.
PRalaypatel07: Add cronjob controller v2
ResultFAILURE
Tests 3 failed / 34 succeeded
Started2020-10-23 21:42
Elapsed36m56s
Revision29de35077a6a479a12c3e44d84cc08c4cf2de388
Refs 93370

Test Failures


verify boilerplate 1.41s

make verify WHAT=boilerplate
Boilerplate header is wrong for: /home/prow/go/src/k8s.io/kubernetes/pkg/controller/cronjob/cronjob_controllerv2_test.go
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify golint 3m11s

make verify WHAT=golint
go: downloading golang.org/x/lint v0.0.0-20200302205851-738671d3881b
go: downloading golang.org/x/tools v0.0.0-20200710042808-f1c4188a97a1
Errors from golint:
pkg/controller/cronjob/cronjob_controllerv2.go:75:1: comment on exported function NewControllerV2 should be of the form "NewControllerV2 ..."
pkg/controller/cronjob/cronjob_controllerv2.go:158:39: error strings should not be capitalized or end with punctuation or a newline
pkg/controller/cronjob/cronjob_controllerv2.go:189:1: error should be the last type when returning multiple items
pkg/controller/cronjob/cronjob_controllerv2.go:418:1: error should be the last type when returning multiple items
pkg/controller/cronjob/cronjob_controllerv2.go:611:9: if block ends with a return statement, so drop this else and outdent its block
pkg/controller/cronjob/config/v1alpha1/conversion.go:33:6: don't use underscores in Go names; func Convert_v1alpha1_CronJobControllerConfiguration_To_config_CronJobControllerConfiguration should be ConvertV1alpha1CronJobControllerConfigurationToConfigCronJobControllerConfiguration
pkg/controller/cronjob/config/v1alpha1/conversion.go:38:6: don't use underscores in Go names; func Convert_config_CronJobControllerConfiguration_To_v1alpha1_CronJobControllerConfiguration should be ConvertConfigCronJobControllerConfigurationToV1alpha1CronJobControllerConfiguration

Please review the above warnings. You can test via "golint" and commit the result.
If the above warnings do not make sense, you can exempt this package from golint
checking by adding it to hack/.golint_failures (if your reviewer is okay with it).
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify staticcheck 5m40s

make verify WHAT=staticcheck
Errors from staticcheck:
pkg/controller/cronjob/cronjob_controllerv2.go:206:2: this value of jobList is never used (SA4006)

Please review the above warnings. You can test via:
  hack/verify-staticcheck.sh <failing package>
If the above warnings do not make sense, you can exempt the line or file. See:
  https://staticcheck.io/docs/#ignoring-problems
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


Show 34 Passed Tests