This job view page is being replaced by Spyglass soon. Check out the new job view.
PRjpbetz: [experimental]: instrument etcd request/response object sizes
ResultFAILURE
Tests 2 failed / 34 succeeded
Started2019-11-09 00:18
Elapsed46m34s
Revisiona66166cf1bca729d12902042828f8e24c6755eac
Refs 85021

Test Failures


verify gofmt 17s

make verify WHAT=gofmt
diff -u ./staging/src/k8s.io/apiserver/pkg/storage/etcd3/store.go.orig ./staging/src/k8s.io/apiserver/pkg/storage/etcd3/store.go
--- ./staging/src/k8s.io/apiserver/pkg/storage/etcd3/store.go.orig	2019-11-09 00:46:02.521746726 +0000
+++ ./staging/src/k8s.io/apiserver/pkg/storage/etcd3/store.go	2019-11-09 00:46:02.521746726 +0000
@@ -885,7 +885,7 @@
 func observeSuccessfulOperation(verb, typeName string, startTime time.Time, requestSize, responseSize uint64) {
 	metrics.RecordEtcdRequestLatency(verb, typeName, startTime)
 	metrics.RecordEtcdRequestSize(verb, typeName, requestSize)
-	metrics.RecordEtcdResponseSize(verb, typeName,responseSize)
+	metrics.RecordEtcdResponseSize(verb, typeName, responseSize)
 	klog.Infof("etcd request: operation:%s type:%q request-size: %d, response-size: %d", verb, typeName, responseSize, responseSize)
 }
 
@@ -896,4 +896,4 @@
 		n += uint64(len(kv.Value))
 	}
 	return n
-}
\ No newline at end of file
+}

Run ./hack/update-gofmt.sh
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify golint 1m55s

make verify WHAT=golint
Errors from golint:
staging/src/k8s.io/apiserver/pkg/storage/etcd3/metrics/metrics.go:108:1: exported function RecordEtcdRequestSize should have comment or be unexported
staging/src/k8s.io/apiserver/pkg/storage/etcd3/metrics/metrics.go:112:1: exported function RecordEtcdResponseSize should have comment or be unexported

Please review the above warnings. You can test via "golint" and commit the result.
If the above warnings do not make sense, you can exempt this package from golint
checking by adding it to hack/.golint_failures (if your reviewer is okay with it).
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


Show 34 Passed Tests