This job view page is being replaced by Spyglass soon. Check out the new job view.
PRwojtek-t: [WIP] Autogenerate conversions for decoding parameters
ResultFAILURE
Tests 3 failed / 33 succeeded
Started2019-10-10 07:13
Elapsed48m15s
Revisionbe0e667ef19ea48408839a7dc311b0ce25064902
Refs 83709

Test Failures


verify generated-files 0.19s

make verify WHAT=generated-files
Unexpected dirty working directory:

  diff --git a/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/custom_conversion_generated.go b/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/custom_conversion_generated.go
  index 402eca8d5a..69a3c903b4 100644
  --- a/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/custom_conversion_generated.go
  +++ b/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/custom_conversion_generated.go
  @@ -42,58 +42,42 @@ func autoConvert_url_Values_To_v1_ListOptions(in *url.Values, out *ListOptions,
   	// WARNING: Field TypeMeta does not have json tag, skipping.
   
   	if values, ok := map[string][]string(*in)["labelSelector"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_string(&values, &out.LabelSelector, s); err != nil {
  -			return err
  -		}
  +		out.LabelSelector = values[0]
   	} else {
   		out.LabelSelector = ""
   	}
   	if values, ok := map[string][]string(*in)["fieldSelector"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_string(&values, &out.FieldSelector, s); err != nil {
  -			return err
  -		}
  +		out.FieldSelector = values[0]
   	} else {
   		out.FieldSelector = ""
   	}
   	if values, ok := map[string][]string(*in)["watch"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_bool(&values, &out.Watch, s); err != nil {
  -			return err
  -		}
  +		// FIXME: out.Watch is of not yet supported  type and requires manual conversion
   	} else {
   		out.Watch = false
   	}
   	if values, ok := map[string][]string(*in)["allowWatchBookmarks"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_bool(&values, &out.AllowWatchBookmarks, s); err != nil {
  -			return err
  -		}
  +		// FIXME: out.AllowWatchBookmarks is of not yet supported  type and requires manual conversion
   	} else {
   		out.AllowWatchBookmarks = false
   	}
   	if values, ok := map[string][]string(*in)["resourceVersion"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_string(&values, &out.ResourceVersion, s); err != nil {
  -			return err
  -		}
  +		out.ResourceVersion = values[0]
   	} else {
   		out.ResourceVersion = ""
   	}
   	if values, ok := map[string][]string(*in)["timeoutSeconds"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_Pointer_int64(&values, &out.TimeoutSeconds, s); err != nil {
  -			return err
  -		}
  +		// FIXME: out.TimeoutSeconds is of not yet supported  type and requires manual conversion
   	} else {
   		out.TimeoutSeconds = nil
   	}
   	if values, ok := map[string][]string(*in)["limit"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_int64(&values, &out.Limit, s); err != nil {
  -			return err
  -		}
  +		// FIXME: out.Limit is of not yet supported  type and requires manual conversion
   	} else {
   		out.Limit = 0
   	}
   	if values, ok := map[string][]string(*in)["continue"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_string(&values, &out.Continue, s); err != nil {
  -			return err
  -		}
  +		out.Continue = values[0]
   	} else {
   		out.Continue = ""
   	}
!!! [1010 07:28:34] Call tree:
!!! [1010 07:28:34]  1: hack/make-rules/../../hack/verify-generated-files.sh:25 kube::util::ensure_clean_working_dir(...)
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify generated-files-remake 0.18s

make verify WHAT=generated-files-remake
Unexpected dirty working directory:

  diff --git a/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/custom_conversion_generated.go b/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/custom_conversion_generated.go
  index 402eca8d5a..69a3c903b4 100644
  --- a/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/custom_conversion_generated.go
  +++ b/staging/src/k8s.io/apimachinery/pkg/apis/meta/v1/custom_conversion_generated.go
  @@ -42,58 +42,42 @@ func autoConvert_url_Values_To_v1_ListOptions(in *url.Values, out *ListOptions,
   	// WARNING: Field TypeMeta does not have json tag, skipping.
   
   	if values, ok := map[string][]string(*in)["labelSelector"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_string(&values, &out.LabelSelector, s); err != nil {
  -			return err
  -		}
  +		out.LabelSelector = values[0]
   	} else {
   		out.LabelSelector = ""
   	}
   	if values, ok := map[string][]string(*in)["fieldSelector"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_string(&values, &out.FieldSelector, s); err != nil {
  -			return err
  -		}
  +		out.FieldSelector = values[0]
   	} else {
   		out.FieldSelector = ""
   	}
   	if values, ok := map[string][]string(*in)["watch"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_bool(&values, &out.Watch, s); err != nil {
  -			return err
  -		}
  +		// FIXME: out.Watch is of not yet supported  type and requires manual conversion
   	} else {
   		out.Watch = false
   	}
   	if values, ok := map[string][]string(*in)["allowWatchBookmarks"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_bool(&values, &out.AllowWatchBookmarks, s); err != nil {
  -			return err
  -		}
  +		// FIXME: out.AllowWatchBookmarks is of not yet supported  type and requires manual conversion
   	} else {
   		out.AllowWatchBookmarks = false
   	}
   	if values, ok := map[string][]string(*in)["resourceVersion"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_string(&values, &out.ResourceVersion, s); err != nil {
  -			return err
  -		}
  +		out.ResourceVersion = values[0]
   	} else {
   		out.ResourceVersion = ""
   	}
   	if values, ok := map[string][]string(*in)["timeoutSeconds"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_Pointer_int64(&values, &out.TimeoutSeconds, s); err != nil {
  -			return err
  -		}
  +		// FIXME: out.TimeoutSeconds is of not yet supported  type and requires manual conversion
   	} else {
   		out.TimeoutSeconds = nil
   	}
   	if values, ok := map[string][]string(*in)["limit"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_int64(&values, &out.Limit, s); err != nil {
  -			return err
  -		}
  +		// FIXME: out.Limit is of not yet supported  type and requires manual conversion
   	} else {
   		out.Limit = 0
   	}
   	if values, ok := map[string][]string(*in)["continue"]; ok && len(values) > 0 {
  -		if err := runtime.Convert_Slice_string_To_string(&values, &out.Continue, s); err != nil {
  -			return err
  -		}
  +		out.Continue = values[0]
   	} else {
   		out.Continue = ""
   	}
!!! [1010 07:28:34] Call tree:
!!! [1010 07:28:34]  1: hack/make-rules/../../hack/verify-generated-files-remake.sh:24 kube::util::ensure_clean_working_dir(...)
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


verify gofmt 17s

make verify WHAT=gofmt
diff -u ./staging/src/k8s.io/apimachinery/pkg/conversion/converter.go.orig ./staging/src/k8s.io/apimachinery/pkg/conversion/converter.go
--- ./staging/src/k8s.io/apimachinery/pkg/conversion/converter.go.orig	2019-10-10 07:38:53.578762279 +0000
+++ ./staging/src/k8s.io/apimachinery/pkg/conversion/converter.go	2019-10-10 07:38:53.578762279 +0000
@@ -20,8 +20,8 @@
 	"fmt"
 	"reflect"
 
-	"runtime/debug"
 	"k8s.io/klog"
+	"runtime/debug"
 )
 
 type typePair struct {
diff -u ./staging/src/k8s.io/code-generator/cmd/conversion-gen/generators/conversion.go.orig ./staging/src/k8s.io/code-generator/cmd/conversion-gen/generators/conversion.go
--- ./staging/src/k8s.io/code-generator/cmd/conversion-gen/generators/conversion.go.orig	2019-10-10 07:38:54.203821588 +0000
+++ ./staging/src/k8s.io/code-generator/cmd/conversion-gen/generators/conversion.go	2019-10-10 07:38:54.204821683 +0000
@@ -1150,7 +1150,7 @@
 }
 
 func (g *genCustomConversion) generateFromUrlValues(inType, outType *types.Type, sw *generator.SnippetWriter) {
-	args :=  generator.Args{
+	args := generator.Args{
 		"inType":  inType,
 		"outType": outType,
 		"Scope":   types.Ref(conversionPackagePath, "Scope"),

Run ./hack/update-gofmt.sh
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


Show 33 Passed Tests