PR #116723 pull-kubernetes-verify #1636805616003452928
Recent runs || View in Spyglass
| PR | SergeyKanzhelev: deprecate ExperimentalHostUserNamespaceDefaulting |
| Result | FAILURE |
| Tests | 1 failed / 36 succeeded |
| Started | |
| Elapsed | 47m5s |
| Revision | 877dd3dcdeaf389fe171956bab5ba409c9c26143 |
| Refs |
116723 |
make verify WHAT=gofmt
go version go1.20.2 linux/amd64
diff ./pkg/kubelet/kubelet.go.orig ./pkg/kubelet/kubelet.go
--- ./pkg/kubelet/kubelet.go.orig
+++ ./pkg/kubelet/kubelet.go
@@ -517,55 +517,55 @@
tracer := kubeDeps.TracerProvider.Tracer(instrumentationScope)
klet := &Kubelet{
- hostname: hostname,
- hostnameOverridden: hostnameOverridden,
- nodeName: nodeName,
- kubeClient: kubeDeps.KubeClient,
- heartbeatClient: kubeDeps.HeartbeatClient,
- onRepeatedHeartbeatFailure: kubeDeps.OnHeartbeatFailure,
- rootDirectory: filepath.Clean(rootDirectory),
- resyncInterval: kubeCfg.SyncFrequency.Duration,
- sourcesReady: config.NewSourcesReady(kubeDeps.PodConfig.SeenAllSources),
- registerNode: registerNode,
- registerWithTaints: registerWithTaints,
- registerSchedulable: registerSchedulable,
- dnsConfigurer: dns.NewConfigurer(kubeDeps.Recorder, nodeRef, nodeIPs, clusterDNS, kubeCfg.ClusterDomain, kubeCfg.ResolverConfig),
- serviceLister: serviceLister,
- serviceHasSynced: serviceHasSynced,
- nodeLister: nodeLister,
- nodeHasSynced: nodeHasSynced,
- streamingConnectionIdleTimeout: kubeCfg.StreamingConnectionIdleTimeout.Duration,
- recorder: kubeDeps.Recorder,
- cadvisor: kubeDeps.CAdvisorInterface,
- cloud: kubeDeps.Cloud,
- externalCloudProvider: cloudprovider.IsExternal(cloudProvider),
- providerID: providerID,
- nodeRef: nodeRef,
- nodeLabels: nodeLabels,
- nodeStatusUpdateFrequency: kubeCfg.NodeStatusUpdateFrequency.Duration,
- nodeStatusReportFrequency: kubeCfg.NodeStatusReportFrequency.Duration,
- os: kubeDeps.OSInterface,
- oomWatcher: oomWatcher,
- cgroupsPerQOS: kubeCfg.CgroupsPerQOS,
- cgroupRoot: kubeCfg.CgroupRoot,
- mounter: kubeDeps.Mounter,
- hostutil: kubeDeps.HostUtil,
- subpather: kubeDeps.Subpather,
- maxPods: int(kubeCfg.MaxPods),
- podsPerCore: int(kubeCfg.PodsPerCore),
- syncLoopMonitor: atomic.Value{},
- daemonEndpoints: daemonEndpoints,
- containerManager: kubeDeps.ContainerManager,
- nodeIPs: nodeIPs,
- nodeIPValidator: validateNodeIP,
- clock: clock.RealClock{},
- enableControllerAttachDetach: kubeCfg.EnableControllerAttachDetach,
- makeIPTablesUtilChains: kubeCfg.MakeIPTablesUtilChains,
- iptablesMasqueradeBit: int(kubeCfg.IPTablesMasqueradeBit),
- iptablesDropBit: int(kubeCfg.IPTablesDropBit),
- keepTerminatedPodVolumes: keepTerminatedPodVolumes,
- nodeStatusMaxImages: nodeStatusMaxImages,
- tracer: tracer,
+ hostname: hostname,
+ hostnameOverridden: hostnameOverridden,
+ nodeName: nodeName,
+ kubeClient: kubeDeps.KubeClient,
+ heartbeatClient: kubeDeps.HeartbeatClient,
+ onRepeatedHeartbeatFailure: kubeDeps.OnHeartbeatFailure,
+ rootDirectory: filepath.Clean(rootDirectory),
+ resyncInterval: kubeCfg.SyncFrequency.Duration,
+ sourcesReady: config.NewSourcesReady(kubeDeps.PodConfig.SeenAllSources),
+ registerNode: registerNode,
+ registerWithTaints: registerWithTaints,
+ registerSchedulable: registerSchedulable,
+ dnsConfigurer: dns.NewConfigurer(kubeDeps.Recorder, nodeRef, nodeIPs, clusterDNS, kubeCfg.ClusterDomain, kubeCfg.ResolverConfig),
+ serviceLister: serviceLister,
+ serviceHasSynced: serviceHasSynced,
+ nodeLister: nodeLister,
+ nodeHasSynced: nodeHasSynced,
+ streamingConnectionIdleTimeout: kubeCfg.StreamingConnectionIdleTimeout.Duration,
+ recorder: kubeDeps.Recorder,
+ cadvisor: kubeDeps.CAdvisorInterface,
+ cloud: kubeDeps.Cloud,
+ externalCloudProvider: cloudprovider.IsExternal(cloudProvider),
+ providerID: providerID,
+ nodeRef: nodeRef,
+ nodeLabels: nodeLabels,
+ nodeStatusUpdateFrequency: kubeCfg.NodeStatusUpdateFrequency.Duration,
+ nodeStatusReportFrequency: kubeCfg.NodeStatusReportFrequency.Duration,
+ os: kubeDeps.OSInterface,
+ oomWatcher: oomWatcher,
+ cgroupsPerQOS: kubeCfg.CgroupsPerQOS,
+ cgroupRoot: kubeCfg.CgroupRoot,
+ mounter: kubeDeps.Mounter,
+ hostutil: kubeDeps.HostUtil,
+ subpather: kubeDeps.Subpather,
+ maxPods: int(kubeCfg.MaxPods),
+ podsPerCore: int(kubeCfg.PodsPerCore),
+ syncLoopMonitor: atomic.Value{},
+ daemonEndpoints: daemonEndpoints,
+ containerManager: kubeDeps.ContainerManager,
+ nodeIPs: nodeIPs,
+ nodeIPValidator: validateNodeIP,
+ clock: clock.RealClock{},
+ enableControllerAttachDetach: kubeCfg.EnableControllerAttachDetach,
+ makeIPTablesUtilChains: kubeCfg.MakeIPTablesUtilChains,
+ iptablesMasqueradeBit: int(kubeCfg.IPTablesMasqueradeBit),
+ iptablesDropBit: int(kubeCfg.IPTablesDropBit),
+ keepTerminatedPodVolumes: keepTerminatedPodVolumes,
+ nodeStatusMaxImages: nodeStatusMaxImages,
+ tracer: tracer,
}
if klet.cloud != nil {
Run ./hack/update-gofmt.sh
go version go1.20.2 linux/amd64
diff ./pkg/kubelet/kubelet.go.orig ./pkg/kubelet/kubelet.go
--- ./pkg/kubelet/kubelet.go.orig
+++ ./pkg/kubelet/kubelet.go
@@ -517,55 +517,55 @@
tracer := kubeDeps.TracerProvider.Tracer(instrumentationScope)
klet := &Kubelet{
- hostname: hostname,
- hostnameOverridden: hostnameOverridden,
- nodeName: nodeName,
- kubeClient: kubeDeps.KubeClient,
- heartbeatClient: kubeDeps.HeartbeatClient,
- onRepeatedHeartbeatFailure: kubeDeps.OnHeartbeatFailure,
- rootDirectory: filepath.Clean(rootDirectory),
- resyncInterval: kubeCfg.SyncFrequency.Duration,
- sourcesReady: config.NewSourcesReady(kubeDeps.PodConfig.SeenAllSources),
- registerNode: registerNode,
- registerWithTaints: registerWithTaints,
- registerSchedulable: registerSchedulable,
- dnsConfigurer: dns.NewConfigurer(kubeDeps.Recorder, nodeRef, nodeIPs, clusterDNS, kubeCfg.ClusterDomain, kubeCfg.ResolverConfig),
- serviceLister: serviceLister,
- serviceHasSynced: serviceHasSynced,
- nodeLister: nodeLister,
- nodeHasSynced: nodeHasSynced,
- streamingConnectionIdleTimeout: kubeCfg.StreamingConnectionIdleTimeout.Duration,
- recorder: kubeDeps.Recorder,
- cadvisor: kubeDeps.CAdvisorInterface,
- cloud: kubeDeps.Cloud,
- externalCloudProvider: cloudprovider.IsExternal(cloudProvider),
- providerID: providerID,
- nodeRef: nodeRef,
- nodeLabels: nodeLabels,
- nodeStatusUpdateFrequency: kubeCfg.NodeStatusUpdateFrequency.Duration,
- nodeStatusReportFrequency: kubeCfg.NodeStatusReportFrequency.Duration,
- os: kubeDeps.OSInterface,
- oomWatcher: oomWatcher,
- cgroupsPerQOS: kubeCfg.CgroupsPerQOS,
- cgroupRoot: kubeCfg.CgroupRoot,
- mounter: kubeDeps.Mounter,
- hostutil: kubeDeps.HostUtil,
- subpather: kubeDeps.Subpather,
- maxPods: int(kubeCfg.MaxPods),
- podsPerCore: int(kubeCfg.PodsPerCore),
- syncLoopMonitor: atomic.Value{},
- daemonEndpoints: daemonEndpoints,
- containerManager: kubeDeps.ContainerManager,
- nodeIPs: nodeIPs,
- nodeIPValidator: validateNodeIP,
- clock: clock.RealClock{},
- enableControllerAttachDetach: kubeCfg.EnableControllerAttachDetach,
- makeIPTablesUtilChains: kubeCfg.MakeIPTablesUtilChains,
- iptablesMasqueradeBit: int(kubeCfg.IPTablesMasqueradeBit),
- iptablesDropBit: int(kubeCfg.IPTablesDropBit),
- keepTerminatedPodVolumes: keepTerminatedPodVolumes,
- nodeStatusMaxImages: nodeStatusMaxImages,
- tracer: tracer,
+ hostname: hostname,
+ hostnameOverridden: hostnameOverridden,
+ nodeName: nodeName,
+ kubeClient: kubeDeps.KubeClient,
+ heartbeatClient: kubeDeps.HeartbeatClient,
+ onRepeatedHeartbeatFailure: kubeDeps.OnHeartbeatFailure,
+ rootDirectory: filepath.Clean(rootDirectory),
+ resyncInterval: kubeCfg.SyncFrequency.Duration,
+ sourcesReady: config.NewSourcesReady(kubeDeps.PodConfig.SeenAllSources),
+ registerNode: registerNode,
+ registerWithTaints: registerWithTaints,
+ registerSchedulable: registerSchedulable,
+ dnsConfigurer: dns.NewConfigurer(kubeDeps.Recorder, nodeRef, nodeIPs, clusterDNS, kubeCfg.ClusterDomain, kubeCfg.ResolverConfig),
+ serviceLister: serviceLister,
+ serviceHasSynced: serviceHasSynced,
+ nodeLister: nodeLister,
+ nodeHasSynced: nodeHasSynced,
+ streamingConnectionIdleTimeout: kubeCfg.StreamingConnectionIdleTimeout.Duration,
+ recorder: kubeDeps.Recorder,
+ cadvisor: kubeDeps.CAdvisorInterface,
+ cloud: kubeDeps.Cloud,
+ externalCloudProvider: cloudprovider.IsExternal(cloudProvider),
+ providerID: providerID,
+ nodeRef: nodeRef,
+ nodeLabels: nodeLabels,
+ nodeStatusUpdateFrequency: kubeCfg.NodeStatusUpdateFrequency.Duration,
+ nodeStatusReportFrequency: kubeCfg.NodeStatusReportFrequency.Duration,
+ os: kubeDeps.OSInterface,
+ oomWatcher: oomWatcher,
+ cgroupsPerQOS: kubeCfg.CgroupsPerQOS,
+ cgroupRoot: kubeCfg.CgroupRoot,
+ mounter: kubeDeps.Mounter,
+ hostutil: kubeDeps.HostUtil,
+ subpather: kubeDeps.Subpather,
+ maxPods: int(kubeCfg.MaxPods),
+ podsPerCore: int(kubeCfg.PodsPerCore),
+ syncLoopMonitor: atomic.Value{},
+ daemonEndpoints: daemonEndpoints,
+ containerManager: kubeDeps.ContainerManager,
+ nodeIPs: nodeIPs,
+ nodeIPValidator: validateNodeIP,
+ clock: clock.RealClock{},
+ enableControllerAttachDetach: kubeCfg.EnableControllerAttachDetach,
+ makeIPTablesUtilChains: kubeCfg.MakeIPTablesUtilChains,
+ iptablesMasqueradeBit: int(kubeCfg.IPTablesMasqueradeBit),
+ iptablesDropBit: int(kubeCfg.IPTablesDropBit),
+ keepTerminatedPodVolumes: keepTerminatedPodVolumes,
+ nodeStatusMaxImages: nodeStatusMaxImages,
+ tracer: tracer,
}
if klet.cloud != nil {
Run ./hack/update-gofmt.sh
from junit_verify.xml
Filter through log files | View test history on testgrid
verify api-groups
verify boilerplate
verify cli-conventions
verify codegen
verify conformance-requirements
verify conformance-yaml
verify description
verify e2e-test-ownership
verify fieldname-docs
verify flags-underscore
verify generated-docs
verify generated-stable-metrics
verify golangci-lint
verify golangci-lint-config
verify govet-levee
verify import-aliases
verify import-boss
verify imports
verify internal-modules
verify mocks
verify netparse-cve
verify no-vendor-cycles
verify non-mutating-validation
verify openapi-spec
verify pkg-names
verify prerelease-lifecycle-tags
verify prometheus-imports
verify publishing-bot
verify readonly-packages
verify shellcheck
verify spelling
verify staging-meta-files
verify test-code
verify test-featuregates
verify test-images
verify yamlfmt
... skipping 996 lines ... } if klet.cloud != nil { Run ./hack/update-gofmt.sh +++ exit code: 1 +++ error: 1 [0;31mFAILED[0m verify-gofmt.sh 6s Verifying verify-golangci-lint-config.sh +++ Running case: verify.golangci-lint-config +++ working dir: /home/prow/go/src/k8s.io/kubernetes +++ command: bash "hack/make-rules/../../hack/verify-golangci-lint-config.sh" hack/golangci.yaml and hack/golangci-strict.yaml are synchronized. ... skipping 1491 lines ... found dependency apimachinery found dependency client-go Done. +++ exit code: 0 [0;32mSUCCESS[0m verify-publishing-bot.py 0s ======================== [0;31mFAILED TESTS[0m ======================== [0;31mhack/make-rules/../../hack/verify-gofmt.sh[0m make: *** [Makefile:128: verify] Error 1 + EXIT_VALUE=2 + set +o xtrace Cleaning up after docker in docker. ================================================================================ Cleaning up after docker 0894b245ab38 ... skipping 4 lines ...