PR #113428 pull-kubernetes-verify #1619237117626421248
Recent runs || View in Spyglass
| PR | mengjiao-liu: Update `pkg/controller/cronjob/` for contextual logging |
| Result | FAILURE |
| Tests | 1 failed / 34 succeeded |
| Started | |
| Elapsed | 46m2s |
| Revision | e5446c57e87edaa65fdd96d9f4701f2459727754 |
| Refs |
113428 |
make verify WHAT=golangci-lint
go: downloading github.com/golangci/golangci-lint v1.50.0
go: downloading github.com/fatih/color v1.13.0
go: downloading github.com/gofrs/flock v0.8.1
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/spf13/cobra v1.5.0
go: downloading github.com/spf13/viper v1.13.0
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
go: downloading github.com/hashicorp/go-version v1.6.0
go: downloading github.com/ldez/gomoddirectives v0.2.3
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/hashicorp/go-multierror v1.1.1
go: downloading github.com/mattn/go-colorable v0.1.13
go: downloading github.com/sirupsen/logrus v1.9.0
go: downloading github.com/stretchr/testify v1.8.0
go: downloading github.com/go-xmlfmt/xmlfmt v0.0.0-20191208150333-d5b6f63a941b
go: downloading github.com/golangci/revgrep v0.0.0-20220804021717-745bb2f7c2e6
go: downloading github.com/mattn/go-isatty v0.0.16
go: downloading golang.org/x/mod v0.7.0
go: downloading 4d63.com/gochecknoglobals v0.1.0
go: downloading github.com/Abirdcfly/dupword v0.0.7
go: downloading github.com/Antonboom/errname v0.1.7
go: downloading github.com/Antonboom/nilnil v0.1.1
go: downloading github.com/BurntSushi/toml v1.2.1
go: downloading github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24
go: downloading github.com/GaijinEntertainment/go-exhaustruct/v2 v2.3.0
go: downloading github.com/OpenPeeDeeP/depguard v1.1.1
go: downloading github.com/alexkohler/prealloc v1.0.0
go: downloading github.com/alingse/asasalint v0.0.11
go: downloading github.com/ashanbrown/forbidigo v1.3.0
go: downloading github.com/ashanbrown/makezero v1.1.1
go: downloading github.com/bkielbasa/cyclop v1.2.0
go: downloading github.com/blizzy78/varnamelen v0.8.0
go: downloading github.com/bombsimon/wsl/v3 v3.3.0
go: downloading github.com/breml/bidichk v0.2.3
go: downloading github.com/breml/errchkjson v0.3.0
go: downloading github.com/butuzov/ireturn v0.1.1
go: downloading github.com/charithe/durationcheck v0.0.9
go: downloading github.com/curioswitch/go-reassign v0.2.0
go: downloading github.com/daixiang0/gci v0.8.0
go: downloading github.com/denis-tingaikin/go-header v0.4.3
go: downloading github.com/esimonov/ifshort v1.0.4
go: downloading github.com/firefart/nonamedreturns v1.0.4
go: downloading github.com/fzipp/gocyclo v0.6.0
go: downloading github.com/go-critic/go-critic v0.6.5
go: downloading github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2
go: downloading github.com/golangci/dupl v0.0.0-20180902072040-3e9179ac440a
go: downloading github.com/golangci/go-misc v0.0.0-20220329215616-d24fe342adfe
go: downloading github.com/golangci/gofmt v0.0.0-20220901101216-f2edd75033f2
go: downloading github.com/golangci/lint-1 v0.0.0-20191013205115-297bf364a8e0
go: downloading github.com/golangci/misspell v0.3.5
go: downloading github.com/golangci/maligned v0.0.0-20180506175553-b1d89398deca
go: downloading github.com/golangci/unconvert v0.0.0-20180507085042-28b1c447d1f4
go: downloading github.com/gordonklaus/ineffassign v0.0.0-20210914165742-4cc7213b9bc8
go: downloading github.com/gostaticanalysis/forcetypeassert v0.1.0
go: downloading github.com/gostaticanalysis/nilerr v0.1.1
go: downloading github.com/hexops/gotextdiff v1.0.3
go: downloading github.com/jgautheron/goconst v1.5.1
go: downloading github.com/jingyugao/rowserrcheck v1.1.1
go: downloading github.com/jirfag/go-printf-func-name v0.0.0-20200119135958-7558a9eaa5af
go: downloading github.com/julz/importas v0.1.0
go: downloading github.com/kisielk/errcheck v1.6.2
go: downloading github.com/kkHAIKE/contextcheck v1.1.2
go: downloading github.com/kulti/thelper v0.6.3
go: downloading github.com/kunwardeep/paralleltest v1.0.6
go: downloading github.com/kyoh86/exportloopref v0.1.8
go: downloading github.com/ldez/tagliatelle v0.3.1
go: downloading github.com/leonklingele/grouper v1.1.0
go: downloading github.com/lufeee/execinquery v1.2.1
go: downloading github.com/maratori/testableexamples v1.0.0
go: downloading github.com/maratori/testpackage v1.1.0
go: downloading github.com/matoous/godox v0.0.0-20210227103229-6504466cf951
go: downloading github.com/mbilski/exhaustivestruct v1.2.0
go: downloading github.com/mgechev/revive v1.2.4
go: downloading github.com/moricho/tparallel v0.2.1
go: downloading github.com/nakabonne/nestif v0.3.1
go: downloading github.com/nishanths/exhaustive v0.8.3
go: downloading github.com/nishanths/predeclared v0.2.2
go: downloading github.com/polyfloyd/go-errorlint v1.0.5
go: downloading github.com/ryancurrah/gomodguard v1.2.4
go: downloading github.com/ryanrolds/sqlclosecheck v0.3.0
go: downloading github.com/sanposhiho/wastedassign/v2 v2.0.6
go: downloading github.com/sashamelentyev/interfacebloat v1.1.0
go: downloading github.com/sashamelentyev/usestdlibvars v1.20.0
go: downloading github.com/securego/gosec/v2 v2.13.1
go: downloading github.com/shazow/go-diff v0.0.0-20160112020656-b6b7b6733b8c
go: downloading github.com/sivchari/containedctx v1.0.2
go: downloading github.com/sivchari/nosnakecase v1.7.0
go: downloading github.com/sivchari/tenv v1.7.0
go: downloading github.com/sonatard/noctx v0.0.1
go: downloading github.com/sourcegraph/go-diff v0.6.1
go: downloading github.com/ssgreg/nlreturn/v2 v2.2.1
go: downloading github.com/stbenjam/no-sprintf-host-port v0.1.1
go: downloading github.com/tdakkota/asciicheck v0.1.1
go: downloading github.com/tetafro/godot v1.4.11
go: downloading github.com/timakin/bodyclose v0.0.0-20210704033933-f49887972144
go: downloading github.com/timonwong/loggercheck v0.9.3
go: downloading github.com/tomarrell/wrapcheck/v2 v2.6.2
go: downloading github.com/tommy-muehle/go-mnd/v2 v2.5.0
go: downloading github.com/ultraware/funlen v0.0.3
go: downloading github.com/ultraware/whitespace v0.0.5
go: downloading github.com/uudashr/gocognit v1.0.6
go: downloading github.com/yagipy/maintidx v1.0.0
go: downloading github.com/yeya24/promlinter v0.2.0
go: downloading gitlab.com/bosi/decorder v0.2.3
go: downloading honnef.co/go/tools v0.4.0-0.dev.0.20221209223220-58c4d7e4b720
go: downloading mvdan.cc/gofumpt v0.4.0
go: downloading mvdan.cc/interfacer v0.0.0-20180901003855-c20040233aed
go: downloading mvdan.cc/unparam v0.0.0-20220706161116-678bad134442
go: downloading github.com/hashicorp/errwrap v1.0.0
go: downloading github.com/fsnotify/fsnotify v1.5.4
go: downloading github.com/mitchellh/mapstructure v1.5.0
go: downloading github.com/spf13/afero v1.8.2
go: downloading github.com/spf13/cast v1.5.0
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading golang.org/x/sys v0.3.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/stretchr/objx v0.4.0
go: downloading github.com/gobwas/glob v0.2.3
go: downloading golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e
go: downloading golang.org/x/sync v0.1.0
go: downloading go.uber.org/zap v1.17.0
go: downloading golang.org/x/text v0.5.0
go: downloading github.com/kisielk/gotool v1.0.0
go: downloading github.com/gostaticanalysis/comment v1.4.2
go: downloading github.com/gostaticanalysis/analysisutil v0.7.1
go: downloading github.com/ettle/strcase v0.1.1
go: downloading github.com/go-toolsmith/astfmt v1.0.0
go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
go: downloading github.com/go-toolsmith/astcast v1.0.0
go: downloading github.com/go-toolsmith/astcopy v1.0.2
go: downloading github.com/go-toolsmith/astequal v1.0.3
go: downloading github.com/go-toolsmith/astp v1.0.0
go: downloading github.com/go-toolsmith/strparse v1.0.0
go: downloading github.com/go-toolsmith/typep v1.0.2
go: downloading github.com/quasilyte/go-ruleguard v0.3.18
go: downloading github.com/quasilyte/regex/syntax v0.0.0-20200407221936-30656e2c4a95
go: downloading github.com/Masterminds/semver v1.5.0
go: downloading github.com/phayes/checkstyle v0.0.0-20170904204023-bfd46e6a821d
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading github.com/nbutton23/zxcvbn-go v0.0.0-20210217022336-fa2cb2858354
go: downloading github.com/fatih/structtag v1.2.0
go: downloading github.com/prometheus/client_golang v1.12.1
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/google/go-cmp v0.5.9
go: downloading mvdan.cc/lint v0.0.0-20170908181259-adc824a0674b
go: downloading github.com/subosito/gotenv v1.4.1
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading gopkg.in/ini.v1 v1.67.0
go: downloading github.com/magiconair/properties v1.8.6
go: downloading github.com/pelletier/go-toml/v2 v2.0.5
go: downloading github.com/chavacava/garif v0.0.0-20220630083739-93517212f375
go: downloading github.com/olekukonko/tablewriter v0.0.5
go: downloading go.uber.org/atomic v1.7.0
go: downloading go.uber.org/multierr v1.6.0
go: downloading github.com/golang/protobuf v1.5.2
go: downloading github.com/quasilyte/gogrep v0.0.0-20220828223005-86e4605de09f
go: downloading github.com/pelletier/go-toml v1.9.5
go: downloading github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.1.2
go: downloading github.com/prometheus/common v0.32.1
go: downloading github.com/prometheus/procfs v0.7.3
go: downloading google.golang.org/protobuf v1.28.0
go: downloading github.com/mattn/go-runewidth v0.0.9
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading sigs.k8s.io/logtools v0.4.1
running golangci-lint
pkg/controller/cronjob/utils.go:164:3: Key positional arguments "missed times" are expected to be alphanumeric and start with either one lowercase or two uppercase letters. Please refer to https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md#name-arguments. (logcheck)
logger.Info("too many missed times", "cronjob", klog.KObj(cj), "missed times", numberOfMissedSchedules)
^
Please review the above warnings. You can test via "./hack/verify-golangci-lint.sh"
If the above warnings do not make sense, you can exempt this warning with a comment
(if your reviewer is okay with it).
In general please prefer to fix the error, we have already disabled specific lints
that the project chooses to ignore.
See: https://golangci-lint.run/usage/false-positives/
go: downloading github.com/golangci/golangci-lint v1.50.0
go: downloading github.com/fatih/color v1.13.0
go: downloading github.com/gofrs/flock v0.8.1
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/spf13/pflag v1.0.5
go: downloading github.com/spf13/cobra v1.5.0
go: downloading github.com/spf13/viper v1.13.0
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading golang.org/x/tools v0.4.1-0.20221208213631-3f74d914ae6d
go: downloading github.com/hashicorp/go-version v1.6.0
go: downloading github.com/ldez/gomoddirectives v0.2.3
go: downloading github.com/mitchellh/go-homedir v1.1.0
go: downloading github.com/hashicorp/go-multierror v1.1.1
go: downloading github.com/mattn/go-colorable v0.1.13
go: downloading github.com/sirupsen/logrus v1.9.0
go: downloading github.com/stretchr/testify v1.8.0
go: downloading github.com/go-xmlfmt/xmlfmt v0.0.0-20191208150333-d5b6f63a941b
go: downloading github.com/golangci/revgrep v0.0.0-20220804021717-745bb2f7c2e6
go: downloading github.com/mattn/go-isatty v0.0.16
go: downloading golang.org/x/mod v0.7.0
go: downloading 4d63.com/gochecknoglobals v0.1.0
go: downloading github.com/Abirdcfly/dupword v0.0.7
go: downloading github.com/Antonboom/errname v0.1.7
go: downloading github.com/Antonboom/nilnil v0.1.1
go: downloading github.com/BurntSushi/toml v1.2.1
go: downloading github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24
go: downloading github.com/GaijinEntertainment/go-exhaustruct/v2 v2.3.0
go: downloading github.com/OpenPeeDeeP/depguard v1.1.1
go: downloading github.com/alexkohler/prealloc v1.0.0
go: downloading github.com/alingse/asasalint v0.0.11
go: downloading github.com/ashanbrown/forbidigo v1.3.0
go: downloading github.com/ashanbrown/makezero v1.1.1
go: downloading github.com/bkielbasa/cyclop v1.2.0
go: downloading github.com/blizzy78/varnamelen v0.8.0
go: downloading github.com/bombsimon/wsl/v3 v3.3.0
go: downloading github.com/breml/bidichk v0.2.3
go: downloading github.com/breml/errchkjson v0.3.0
go: downloading github.com/butuzov/ireturn v0.1.1
go: downloading github.com/charithe/durationcheck v0.0.9
go: downloading github.com/curioswitch/go-reassign v0.2.0
go: downloading github.com/daixiang0/gci v0.8.0
go: downloading github.com/denis-tingaikin/go-header v0.4.3
go: downloading github.com/esimonov/ifshort v1.0.4
go: downloading github.com/firefart/nonamedreturns v1.0.4
go: downloading github.com/fzipp/gocyclo v0.6.0
go: downloading github.com/go-critic/go-critic v0.6.5
go: downloading github.com/golangci/check v0.0.0-20180506172741-cfe4005ccda2
go: downloading github.com/golangci/dupl v0.0.0-20180902072040-3e9179ac440a
go: downloading github.com/golangci/go-misc v0.0.0-20220329215616-d24fe342adfe
go: downloading github.com/golangci/gofmt v0.0.0-20220901101216-f2edd75033f2
go: downloading github.com/golangci/lint-1 v0.0.0-20191013205115-297bf364a8e0
go: downloading github.com/golangci/misspell v0.3.5
go: downloading github.com/golangci/maligned v0.0.0-20180506175553-b1d89398deca
go: downloading github.com/golangci/unconvert v0.0.0-20180507085042-28b1c447d1f4
go: downloading github.com/gordonklaus/ineffassign v0.0.0-20210914165742-4cc7213b9bc8
go: downloading github.com/gostaticanalysis/forcetypeassert v0.1.0
go: downloading github.com/gostaticanalysis/nilerr v0.1.1
go: downloading github.com/hexops/gotextdiff v1.0.3
go: downloading github.com/jgautheron/goconst v1.5.1
go: downloading github.com/jingyugao/rowserrcheck v1.1.1
go: downloading github.com/jirfag/go-printf-func-name v0.0.0-20200119135958-7558a9eaa5af
go: downloading github.com/julz/importas v0.1.0
go: downloading github.com/kisielk/errcheck v1.6.2
go: downloading github.com/kkHAIKE/contextcheck v1.1.2
go: downloading github.com/kulti/thelper v0.6.3
go: downloading github.com/kunwardeep/paralleltest v1.0.6
go: downloading github.com/kyoh86/exportloopref v0.1.8
go: downloading github.com/ldez/tagliatelle v0.3.1
go: downloading github.com/leonklingele/grouper v1.1.0
go: downloading github.com/lufeee/execinquery v1.2.1
go: downloading github.com/maratori/testableexamples v1.0.0
go: downloading github.com/maratori/testpackage v1.1.0
go: downloading github.com/matoous/godox v0.0.0-20210227103229-6504466cf951
go: downloading github.com/mbilski/exhaustivestruct v1.2.0
go: downloading github.com/mgechev/revive v1.2.4
go: downloading github.com/moricho/tparallel v0.2.1
go: downloading github.com/nakabonne/nestif v0.3.1
go: downloading github.com/nishanths/exhaustive v0.8.3
go: downloading github.com/nishanths/predeclared v0.2.2
go: downloading github.com/polyfloyd/go-errorlint v1.0.5
go: downloading github.com/ryancurrah/gomodguard v1.2.4
go: downloading github.com/ryanrolds/sqlclosecheck v0.3.0
go: downloading github.com/sanposhiho/wastedassign/v2 v2.0.6
go: downloading github.com/sashamelentyev/interfacebloat v1.1.0
go: downloading github.com/sashamelentyev/usestdlibvars v1.20.0
go: downloading github.com/securego/gosec/v2 v2.13.1
go: downloading github.com/shazow/go-diff v0.0.0-20160112020656-b6b7b6733b8c
go: downloading github.com/sivchari/containedctx v1.0.2
go: downloading github.com/sivchari/nosnakecase v1.7.0
go: downloading github.com/sivchari/tenv v1.7.0
go: downloading github.com/sonatard/noctx v0.0.1
go: downloading github.com/sourcegraph/go-diff v0.6.1
go: downloading github.com/ssgreg/nlreturn/v2 v2.2.1
go: downloading github.com/stbenjam/no-sprintf-host-port v0.1.1
go: downloading github.com/tdakkota/asciicheck v0.1.1
go: downloading github.com/tetafro/godot v1.4.11
go: downloading github.com/timakin/bodyclose v0.0.0-20210704033933-f49887972144
go: downloading github.com/timonwong/loggercheck v0.9.3
go: downloading github.com/tomarrell/wrapcheck/v2 v2.6.2
go: downloading github.com/tommy-muehle/go-mnd/v2 v2.5.0
go: downloading github.com/ultraware/funlen v0.0.3
go: downloading github.com/ultraware/whitespace v0.0.5
go: downloading github.com/uudashr/gocognit v1.0.6
go: downloading github.com/yagipy/maintidx v1.0.0
go: downloading github.com/yeya24/promlinter v0.2.0
go: downloading gitlab.com/bosi/decorder v0.2.3
go: downloading honnef.co/go/tools v0.4.0-0.dev.0.20221209223220-58c4d7e4b720
go: downloading mvdan.cc/gofumpt v0.4.0
go: downloading mvdan.cc/interfacer v0.0.0-20180901003855-c20040233aed
go: downloading mvdan.cc/unparam v0.0.0-20220706161116-678bad134442
go: downloading github.com/hashicorp/errwrap v1.0.0
go: downloading github.com/fsnotify/fsnotify v1.5.4
go: downloading github.com/mitchellh/mapstructure v1.5.0
go: downloading github.com/spf13/afero v1.8.2
go: downloading github.com/spf13/cast v1.5.0
go: downloading github.com/spf13/jwalterweatherman v1.1.0
go: downloading golang.org/x/sys v0.3.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/stretchr/objx v0.4.0
go: downloading github.com/gobwas/glob v0.2.3
go: downloading golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e
go: downloading golang.org/x/sync v0.1.0
go: downloading go.uber.org/zap v1.17.0
go: downloading golang.org/x/text v0.5.0
go: downloading github.com/kisielk/gotool v1.0.0
go: downloading github.com/gostaticanalysis/comment v1.4.2
go: downloading github.com/gostaticanalysis/analysisutil v0.7.1
go: downloading github.com/ettle/strcase v0.1.1
go: downloading github.com/go-toolsmith/astfmt v1.0.0
go: downloading golang.org/x/exp/typeparams v0.0.0-20221208152030-732eee02a75a
go: downloading github.com/go-toolsmith/astcast v1.0.0
go: downloading github.com/go-toolsmith/astcopy v1.0.2
go: downloading github.com/go-toolsmith/astequal v1.0.3
go: downloading github.com/go-toolsmith/astp v1.0.0
go: downloading github.com/go-toolsmith/strparse v1.0.0
go: downloading github.com/go-toolsmith/typep v1.0.2
go: downloading github.com/quasilyte/go-ruleguard v0.3.18
go: downloading github.com/quasilyte/regex/syntax v0.0.0-20200407221936-30656e2c4a95
go: downloading github.com/Masterminds/semver v1.5.0
go: downloading github.com/phayes/checkstyle v0.0.0-20170904204023-bfd46e6a821d
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading github.com/nbutton23/zxcvbn-go v0.0.0-20210217022336-fa2cb2858354
go: downloading github.com/fatih/structtag v1.2.0
go: downloading github.com/prometheus/client_golang v1.12.1
go: downloading github.com/prometheus/client_model v0.2.0
go: downloading github.com/google/go-cmp v0.5.9
go: downloading mvdan.cc/lint v0.0.0-20170908181259-adc824a0674b
go: downloading github.com/subosito/gotenv v1.4.1
go: downloading github.com/hashicorp/hcl v1.0.0
go: downloading gopkg.in/ini.v1 v1.67.0
go: downloading github.com/magiconair/properties v1.8.6
go: downloading github.com/pelletier/go-toml/v2 v2.0.5
go: downloading github.com/chavacava/garif v0.0.0-20220630083739-93517212f375
go: downloading github.com/olekukonko/tablewriter v0.0.5
go: downloading go.uber.org/atomic v1.7.0
go: downloading go.uber.org/multierr v1.6.0
go: downloading github.com/golang/protobuf v1.5.2
go: downloading github.com/quasilyte/gogrep v0.0.0-20220828223005-86e4605de09f
go: downloading github.com/pelletier/go-toml v1.9.5
go: downloading github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.1.2
go: downloading github.com/prometheus/common v0.32.1
go: downloading github.com/prometheus/procfs v0.7.3
go: downloading google.golang.org/protobuf v1.28.0
go: downloading github.com/mattn/go-runewidth v0.0.9
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.1
go: downloading sigs.k8s.io/logtools v0.4.1
running golangci-lint
pkg/controller/cronjob/utils.go:164:3: Key positional arguments "missed times" are expected to be alphanumeric and start with either one lowercase or two uppercase letters. Please refer to https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/migration-to-structured-logging.md#name-arguments. (logcheck)
logger.Info("too many missed times", "cronjob", klog.KObj(cj), "missed times", numberOfMissedSchedules)
^
Please review the above warnings. You can test via "./hack/verify-golangci-lint.sh"
If the above warnings do not make sense, you can exempt this warning with a comment
(if your reviewer is okay with it).
In general please prefer to fix the error, we have already disabled specific lints
that the project chooses to ignore.
See: https://golangci-lint.run/usage/false-positives/
from junit_verify.xml
Filter through log files | View test history on testgrid
verify api-groups
verify boilerplate
verify cli-conventions
verify codegen
verify conformance-requirements
verify conformance-yaml
verify description
verify e2e-test-ownership
verify flags-underscore
verify generated-docs
verify generated-stable-metrics
verify gofmt
verify govet
verify import-aliases
verify import-boss
verify imports
verify internal-modules
verify mocks
verify netparse-cve
verify no-vendor-cycles
verify non-mutating-validation
verify openapi-spec
verify pkg-names
verify prerelease-lifecycle-tags
verify prometheus-imports
verify publishing-bot
verify readonly-packages
verify shellcheck
verify spelling
verify staging-meta-files
verify test-code
verify test-featuregates
verify test-images
verify yamlfmt
... skipping 958 lines ... running golangci-lint for /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/sample-cli-plugin running golangci-lint for /home/prow/go/src/k8s.io/kubernetes/staging/src/k8s.io/sample-controller Please review the above warnings. You can test via "./hack/verify-golangci-lint.sh" If the above warnings do not make sense, you can exempt this warning with a comment (if your reviewer is okay with it). In general please prefer to fix the error, we have already disabled specific lints that the project chooses to ignore. See: https://golangci-lint.run/usage/false-positives/ +++ exit code: 1 +++ error: 1 [0;31mFAILED[0m verify-golangci-lint.sh 929s Skipping verify-govet-levee.sh Verifying verify-govet.sh +++ Running case: verify.govet +++ working dir: /home/prow/go/src/k8s.io/kubernetes +++ command: bash "hack/make-rules/../../hack/verify-govet.sh" ... skipping 922 lines ... processing : noderesourcetopology-api found dependency code-generator Done. +++ exit code: 0 [0;32mSUCCESS[0m verify-publishing-bot.py 0s ======================== [0;31mFAILED TESTS[0m ======================== [0;31mhack/make-rules/../../hack/verify-golangci-lint.sh[0m make: *** [Makefile:128: verify] Error 1 + EXIT_VALUE=2 + set +o xtrace Cleaning up after docker in docker. ================================================================================ Cleaning up after docker d4fe9ccf51d6 ... skipping 4 lines ...