This job view page is being replaced by Spyglass soon. Check out the new job view.
PRmengjiao-liu: Improve unit test coverage in `pkg/util/taints/`
ResultFAILURE
Tests 1 failed / 42 succeeded
Started2022-06-23 10:25
Elapsed49m4s
Revision488843e818c7782c53cd2af763fa4ba5875ef748
Refs 108332

Test Failures


verify gofmt 5.96s

make verify WHAT=gofmt
diff -u ./pkg/util/taints/taints_test.go.orig ./pkg/util/taints/taints_test.go
--- ./pkg/util/taints/taints_test.go.orig	2022-06-23 10:46:46.400488768 +0000
+++ ./pkg/util/taints/taints_test.go	2022-06-23 10:46:46.400488768 +0000
@@ -59,7 +59,7 @@
 			node: &v1.Node{
 				Spec: v1.NodeSpec{Taints: []v1.Taint{taint}},
 			},
-			taint: &taintNew,
+			taint:          &taintNew,
 			expectedUpdate: true,
 			expectedTaints: []v1.Taint{taint, taintNew},
 		},
@@ -208,7 +208,7 @@
 		expectedTaints []v1.Taint
 	}{
 		{
-			name:   "Filter out nothing",
+			name: "Filter out nothing",
 			fn: func(t *v1.Taint) bool {
 				if t.Key == v1.TaintNodeUnschedulable {
 					return true
@@ -218,7 +218,7 @@
 			expectedTaints: []v1.Taint{},
 		},
 		{
-			name:   "Filter out a subset",
+			name: "Filter out a subset",
 			fn: func(t *v1.Taint) bool {
 				if t.Effect == v1.TaintEffectNoExecute {
 					return true
@@ -236,7 +236,7 @@
 	for _, tc := range testcases {
 		taintsAfterFilter := TaintSetFilter(testTaints, tc.fn)
 		if !reflect.DeepEqual(tc.expectedTaints, taintsAfterFilter) {
-			t.Errorf("[%s] expect to see taint list %#v, but got: %#v", tc.name, tc.expectedTaints,taintsAfterFilter)
+			t.Errorf("[%s] expect to see taint list %#v, but got: %#v", tc.name, tc.expectedTaints, taintsAfterFilter)
 		}
 	}
 }

Run ./hack/update-gofmt.sh
				
				Click to see stdout/stderrfrom junit_verify.xml

Filter through log files | View test history on testgrid


Show 42 Passed Tests

Error lines from build-log.txt

... skipping 1572 lines ...
 		}
 	}
 }

Run ./hack/update-gofmt.sh
+++ exit code: 1
+++ error: 1
FAILED   verify-gofmt.sh	6s
Verifying verify-golangci-lint.sh

+++ Running case: verify.golangci-lint 
+++ working dir: /home/prow/go/src/k8s.io/kubernetes
+++ command: bash "hack/make-rules/../../hack/verify-golangci-lint.sh"
installing golangci-lint and logcheck plugin from hack/tools into /home/prow/go/src/k8s.io/kubernetes/_output/local/bin
... skipping 1024 lines ...
  found dependency client-go
  found dependency api
Done.
+++ exit code: 0
SUCCESS  verify-publishing-bot.py	1s
========================
FAILED TESTS
========================
hack/make-rules/../../hack/verify-gofmt.sh
make: *** [Makefile:130: verify] Error 1
+ EXIT_VALUE=2
+ set +o xtrace
Cleaning up after docker in docker.
================================================================================
Cleaning up after docker
c9b357e6c325
... skipping 4 lines ...