PR | mengjiao-liu: Improve unit test coverage in `pkg/util/taints/` |
Result | FAILURE |
Tests | 1 failed / 42 succeeded |
Started | |
Elapsed | 49m4s |
Revision | 488843e818c7782c53cd2af763fa4ba5875ef748 |
Refs |
108332 |
make verify WHAT=gofmt
diff -u ./pkg/util/taints/taints_test.go.orig ./pkg/util/taints/taints_test.go --- ./pkg/util/taints/taints_test.go.orig 2022-06-23 10:46:46.400488768 +0000 +++ ./pkg/util/taints/taints_test.go 2022-06-23 10:46:46.400488768 +0000 @@ -59,7 +59,7 @@ node: &v1.Node{ Spec: v1.NodeSpec{Taints: []v1.Taint{taint}}, }, - taint: &taintNew, + taint: &taintNew, expectedUpdate: true, expectedTaints: []v1.Taint{taint, taintNew}, }, @@ -208,7 +208,7 @@ expectedTaints []v1.Taint }{ { - name: "Filter out nothing", + name: "Filter out nothing", fn: func(t *v1.Taint) bool { if t.Key == v1.TaintNodeUnschedulable { return true @@ -218,7 +218,7 @@ expectedTaints: []v1.Taint{}, }, { - name: "Filter out a subset", + name: "Filter out a subset", fn: func(t *v1.Taint) bool { if t.Effect == v1.TaintEffectNoExecute { return true @@ -236,7 +236,7 @@ for _, tc := range testcases { taintsAfterFilter := TaintSetFilter(testTaints, tc.fn) if !reflect.DeepEqual(tc.expectedTaints, taintsAfterFilter) { - t.Errorf("[%s] expect to see taint list %#v, but got: %#v", tc.name, tc.expectedTaints,taintsAfterFilter) + t.Errorf("[%s] expect to see taint list %#v, but got: %#v", tc.name, tc.expectedTaints, taintsAfterFilter) } } } Run ./hack/update-gofmt.shfrom junit_verify.xml
diff -u ./pkg/util/taints/taints_test.go.orig ./pkg/util/taints/taints_test.go --- ./pkg/util/taints/taints_test.go.orig 2022-06-23 10:46:46.400488768 +0000 +++ ./pkg/util/taints/taints_test.go 2022-06-23 10:46:46.400488768 +0000 @@ -59,7 +59,7 @@ node: &v1.Node{ Spec: v1.NodeSpec{Taints: []v1.Taint{taint}}, }, - taint: &taintNew, + taint: &taintNew, expectedUpdate: true, expectedTaints: []v1.Taint{taint, taintNew}, }, @@ -208,7 +208,7 @@ expectedTaints []v1.Taint }{ { - name: "Filter out nothing", + name: "Filter out nothing", fn: func(t *v1.Taint) bool { if t.Key == v1.TaintNodeUnschedulable { return true @@ -218,7 +218,7 @@ expectedTaints: []v1.Taint{}, }, { - name: "Filter out a subset", + name: "Filter out a subset", fn: func(t *v1.Taint) bool { if t.Effect == v1.TaintEffectNoExecute { return true @@ -236,7 +236,7 @@ for _, tc := range testcases { taintsAfterFilter := TaintSetFilter(testTaints, tc.fn) if !reflect.DeepEqual(tc.expectedTaints, taintsAfterFilter) { - t.Errorf("[%s] expect to see taint list %#v, but got: %#v", tc.name, tc.expectedTaints,taintsAfterFilter) + t.Errorf("[%s] expect to see taint list %#v, but got: %#v", tc.name, tc.expectedTaints, taintsAfterFilter) } } } Run ./hack/update-gofmt.sh
Filter through log files | View test history on testgrid
verify api-groups
verify boilerplate
verify cli-conventions
verify codegen
verify conformance-requirements
verify conformance-yaml
verify description
verify e2e-test-ownership
verify flags-underscore
verify generated-device-plugin
verify generated-docs
verify generated-files
verify generated-kms
verify generated-kubelet-plugin-registration
verify generated-pod-resources
verify generated-protobuf
verify generated-runtime
verify generated-stable-metrics
verify generated-swagger-docs
verify golangci-lint
verify govet
verify import-aliases
verify import-boss
verify imports
verify internal-modules
verify mocks
verify netparse-cve
verify no-vendor-cycles
verify non-mutating-validation
verify openapi-spec
verify pkg-names
verify prerelease-lifecycle-tags
verify prometheus-imports
verify publishing-bot
verify readonly-packages
verify shellcheck
verify spelling
verify staging-meta-files
verify test-code
verify test-featuregates
verify test-images
verify yamlfmt
... skipping 1572 lines ... } } } Run ./hack/update-gofmt.sh +++ exit code: 1 +++ error: 1 [0;31mFAILED[0m verify-gofmt.sh 6s Verifying verify-golangci-lint.sh +++ Running case: verify.golangci-lint +++ working dir: /home/prow/go/src/k8s.io/kubernetes +++ command: bash "hack/make-rules/../../hack/verify-golangci-lint.sh" installing golangci-lint and logcheck plugin from hack/tools into /home/prow/go/src/k8s.io/kubernetes/_output/local/bin ... skipping 1024 lines ... found dependency client-go found dependency api Done. +++ exit code: 0 [0;32mSUCCESS[0m verify-publishing-bot.py 1s ======================== [0;31mFAILED TESTS[0m ======================== [0;31mhack/make-rules/../../hack/verify-gofmt.sh[0m make: *** [Makefile:130: verify] Error 1 + EXIT_VALUE=2 + set +o xtrace Cleaning up after docker in docker. ================================================================================ Cleaning up after docker c9b357e6c325 ... skipping 4 lines ...